[Kde-games-devel] Re: Small KBounce bug

[Andreas Beckermann]

On Friday 24 January 2003 20:28, Albert Astals Cid wrote:
> I've found a little bug in KBounce reported in this bug report
> http://bugs.kde.org/show_bug.cgi?id=53119
>
> Then I downloaded the sources of kdegames 3.1-rc6 and added the 3 or 4
> lines necessary to stop the bug from appearing, the bug is attached in the
> comment of the bug report.
>
> Can someone with CVS access please update the code.
>
> Thanks.

Hi
can you please
- not create .tar.bz2 files for 5 lines of diff? Just attach the diff instead
- use cvs diff > diff instead of plain diff if possible
- if you really want to use plain diff then use -Naur. This makes diffs usable

And... Did you look at the patch / try it ? I am pretty sure it won't work:
124c124
<     pause_button = KStdGameAction::pause(this, SLOT(pauseGame()), 
actionCollection());
---
>     KStdGameAction::pause(this, SLOT(pauseGame()), actionCollection());
144,146d143
<       // untoggles the pause button in case it was toggled
<       pause_button -> setChecked(false);

Since there is no line "pause_button = KStdGameAction(...)" you can't remove 
it ;)

Oh and please name it m_pauseButton instead, in order to keep consistency with 
the rest of the code.

Please resend the patch to this list (this saves me the trouble of searching 
for the correct lines myself) using cvs diff > diff.

CU
Andi