[Kde-games-devel] KBattleship patch, commit or not to commit

[Albert Astals Cid]

commit or not to commit, That is the question.

The attached patch corrects bug 69382 
http://bugs.kde.org/show_bug.cgi?id=69382

In short it removes the custom kbattleship highscore dialog and uses the 
kdegames one. 

The good thing is the consistent look along kdegames, the removal of 
khighscoredialog.cpp, khighscoredialog.h and highscoreDlg.ui (so there's less 
code to mantain and less code to compile) and the possibility of using system 
wide highscores thanks to libkdegames.

The bad thing is that the previous score dialog stored data in a diferent way 
from the kdegames one, so highscores are lost. To fix that i could do some 
code that checked if the highscores file had the old score syntax and port 
the scores to the new score syntax, but i think that is bad having that code 
in kbattelship forever.

What do you think?

Albert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patchBug69382
Type: text/x-diff
Size: 4704 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20031214/3f2cacf2/patchBug69382.bin