[Bug 286494] devel/cmake*: Respect CFLAGS after bootstrapping

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286494

Jason E. Hale <jhale at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
              Flags|                            |maintainer-feedback+

--- Comment #1 from Jason E. Hale <jhale at FreeBSD.org> ---
As far as I can tell, the CMake bootstrap picks up on CFLAGS/CXXFLAGS set in
/etc/make.conf, so I don't know what koobs' problem is or why he didn't bring
it up to kde@ himself. His commit message sound kind of annoyed, like this has
been a long-standing problem that has been willfully ignored, but this is the
very first PR I'm seeing for this issue.

By the current title of this PR, you're suggesting that CMake doesn't support
CFLAGS/CXXFLAGS post-bootstrap, though, which I don't see, either. Changing
"devel/cmake-core/files/InitialCache.cmake.in" would only affect the bootstrap.

Most of the project is C++, but there are some C components, as well. CFLAGS
should propagate to CXXFLAGS, but not the other way around. As an experiment, I
added "-funroll-loops" to CFLAGS and the bootstrap reports:

C compiler on this system is: cc -O2 -pipe -funroll-loops  -I/usr/include
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing 
C++ compiler on this system is: c++ -O2 -pipe -funroll-loops -I/usr/include
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  
-D__BSD_VISIBLE -isystem /usr/local/include

With the koobs patch:
C compiler on this system is: cc -O2 -pipe -funroll-loops  -I/usr/include
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing   
C++ compiler on this system is: c++ -O2 -pipe -funroll-loops -I/usr/include
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  
-D__BSD_VISIBLE -isystem /usr/local/include    

Both the exact same.

I'm really confused as to what problem we're trying to solve, since it seems to
work as intended.

-- 
You are receiving this mail because:
You are the assignee for the bug.