[Bug 279908] devel/cmake: autogen (moc/uic) processes don't respect MAKE_JOBS_NUMBER

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279908

Jason E. Hale <jhale at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Open                        |Closed

--- Comment #6 from Jason E. Hale <jhale at FreeBSD.org> ---
(In reply to Anton Saietskii from comment #4)

> I can confirm that with the patch, no excess moc processes being spawned.

Thanks for confirming! Committed.

> BTW, either CMake documentation is incorrect or it's the bug.
> I have 1 CPU, 4 physical cores, HT -- and previously, 8 moc processed were spawned,
> which doesn't align with "number of threads/processes to the number of physical CPUs"
> in any way.
> However, I don't work with CMake extensively, so not willing to report this upstream.

It's probably more of a documentation bug by means of generalization. CMake, at
least for FreeBSD, uses what is reported by `sysctl -n hw.ncpu` to determine
the number of CPUs for this purpose. On my laptop, I also have 1 CPU with 4
physical cores with HT and the output of that command is "8", so it would make
sense that up to and including 8 processes would be spawned before this change.

> P.S. I wish someone from gecko@ could review PRs so quick...

I don't like commenting on FreeBSD ports teams that I'm not involved with, but
some are way more understaffed than others and sometimes sadly only consist of
one person, so it may take more time for them to address PRs. We at kde@ are
currently a relatively robust team and do our best to stay on top of things.
Even still, we do miss things such as this and appreciate your report.

-- 
You are receiving this mail because:
You are the assignee for the bug.