[Bug 276792] devel/cmake*: Make port Makefiles more consistent

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276792

Jason E. Hale <jhale at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
              Flags|maintainer-feedback?(kde at Fr |maintainer-feedback+
                   |eeBSD.org)                  |

--- Comment #1 from Jason E. Hale <jhale at FreeBSD.org> ---
What tools did you check with when making this patch? Prior to, portclippy(1)
had 2 suggestions for cmake-core alone, now it has 4. Sorry to be so blunt, but
this seems like a lot of unnecessary churn and putting CXXFLAGS/LDFLAGS above
CONFIGURE_ARGS/CMAKE_ARGS is just gross. The configure stage comes first, after
all.

Good catch with the duplicate DISTINFO_FILE in cmake-man, but it definitely
doesn't belong between LICENSE and BUILD_DEPENDS. We can surely make some
improvements in the cmake ports, at least to be consistent, but let's at least
try to make portlint(1) and portclippy(1) happy.

-- 
You are receiving this mail because:
You are the assignee for the bug.