[Bug 251939] math/eigen3: does it really need a GL dependency?

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251939

Adriaan de Groot <adridg at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adridg at freebsd.org

--- Comment #8 from Adriaan de Groot <adridg at freebsd.org> ---
Looking at the code (cloned from gitlab), OpenGL is used in two places:

- unsupported/test
- demos/opengl

The first one is "unsupported" which just means it is not part of the
core-community release of Eigen; it's a user contribution. The package isn't
even used unless specifically the option EIGEN_TEST_OPENGL is **also** set
(defaults OFF). When it is used, um .. as far as I can tell there is one extra
test that is built. There is no other change.

The second one is a Qt4-based demo; there is no Qt4.

Neither of these are reasons to make math/eigen3 depend on OpenGL; one could
argue that you want to test everything, but the current setup is not doing
that.
If finding OpenGL in a dirty build environment is somehow a problem, that
should be used as a reason to **possibly** make it a dependency, but a more
likely thing to do is to suppress finding it: CMAKE_DISABLE_FIND_PACKAGE is the
right thing to do there.

**Consumers** of math/eigen3 that can use OpenGL should enable OpenGL in their
own ports.

-- 
You are receiving this mail because:
You are the assignee for the bug.