[Bug 246659] KDE Frameworks 5.70: Could not find the program 'konsole'

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246659

--- Comment #4 from commit-hook at freebsd.org ---
A commit references this bug:

Author: tcberner
Date: Sun May 24 20:22:13 UTC 2020
New revision: 536419
URL: https://svnweb.freebsd.org/changeset/ports/536419

Log:
  devel/kf5-kio: add upstream bug fix: "Could not find the program ?konsole?"

  From upstrams [1] bug report

  Fix service file specifying 'Run in terminal' giving an error code 100

  Happens because KIO::DesktopExecParser::resultingArguments() prepends
  the terminal application to the command line.  If this is a relative path,
  as it is most likely to be (and will be in the default 'konsole' case),
  the "realExecutable" check in KProcessRunner::KProcessRunner() is triggered
  and the job aborts with an error.

  Expand the specified terminal executable into a full path in
resultingArguments(),
  and return an error immediately if it cannot be found.  This full terminal
path
  is not relative for the KProcessRunner::KProcessRunner() check and does not
fail.

  Check that resultingArguments() is not empty (an error return) before
accessing
  the first word of the command, so that it does not assert if the list is
empty.
  Also only call resultingArguments() once.

  [1] https://bugs.kde.org/show_bug.cgi?id=421374

  PR:           246659
  Reported by:  Serge Volkov <sv at ulstu.ru>

Changes:
  head/devel/kf5-kio/Makefile
  head/devel/kf5-kio/files/
  head/devel/kf5-kio/files/patch-git_6452a34cf

-- 
You are receiving this mail because:
You are the assignee for the bug.