[Bug 252229] graphics/ksnip dumps core

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252229

--- Comment #4 from commit-hook at FreeBSD.org ---
A commit references this bug:

Author: adridg
Date: Wed Dec 30 21:07:11 UTC 2020
New revision: 559684
URL: https://svnweb.freebsd.org/changeset/ports/559684

Log:
  Patch UB in graphics/ksnip

  Various functions did if-linux-else-windows-else-apple, leaving us behind;
  when those functions are supposed to return a value, but don't, that's
  Undefined Behavior. It's allowed to crash, or do something else. There were
  already patches adding the "other" case, here's a handful more of them.

  I chose to patch the existing port, rather than trying to chase an
  update to the recently-released 1.8.0, because that's a little less
  work *right now*.

  PR:           252229
  Reported by:  Guido Kollerie

Changes:
  head/graphics/ksnip/Makefile
 
head/graphics/ksnip/files/patch-src_common_adapter_fileDialog_FileDialogAdapterFactory.cpp
 
head/graphics/ksnip/files/patch-src_common_adapter_fileDialog_FileDialogAdapterFactory.h
  head/graphics/ksnip/files/patch-src_common_platform_HdpiScaler.cpp
  head/graphics/ksnip/files/patch-src_gui_widgetHider_WidgetHiderFactory.cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.