[Bug 249024] cmake.mk: Add USES=cmake:testing to facilitate defining test targets for cmake-based ports

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249024

Adriaan de Groot <adridg at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adridg at freebsd.org

--- Comment #5 from Adriaan de Groot <adridg at freebsd.org> ---
This looks mostly sensible to me:
- it only adds testing and BUILD_TESTING via the framework when a port
explicitly mentions `USES=cmake:testing`.
- it looks awfully over-engineered with possibilities for ON, OFF, different
targets, ... but as long as that complexity is hidden and documented in the
framework and the basic interface (`USES=cmake:testing`) is simple, I don't
object to that. I wonder what ports will be using it.
- potentially re-building the entire port with new flags for do-test seems a
bit over-the-top, perhaps the default setup could push `BUILD_TESTING` to the
normal `CMAKE_ARGS` (like an unconditional `include(CTest)` would).

So, overall: LGTM.

-- 
You are receiving this mail because:
You are the assignee for the bug.