[Bug 235898] Mk/Uses/qt.mk: Complain about components with an unknown suffix instead of silently accepting them

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Feb 20 21:24:38 GMT 2019


--- Comment #2 from commit-hook at freebsd.org ---
A commit references this bug:

Author: tobik
Date: Wed Feb 20 21:24:33 UTC 2019
New revision: 493464
URL: https://svnweb.freebsd.org/changeset/ports/493464

  Mk/Uses/qt.mk: Complain about components with an unknown suffix

  Normally, USE_QT complains about unknown components with

        ===>  $PKGNAME cannot be installed: unknown USE_QT component

  However this fails if the component has a suffix starting with `_`.
  For example

        USE_QT= buildtools_build,core

  or even a simple

        USE_QT= buildtools_buld

  is silently accepted, but they do not do anything.  Only components
  with _build and _run suffixes should be accepted.

  Amend the regular expression we use for this to be stricter.  It
  is currently over eager.  Since we only have two cases to cover
  here we can spell them out explictly instead.

  PR:           235898
  Approved by:  kde (tcberner)
  Differential Revision:        https://reviews.freebsd.org/D19267


You are receiving this mail because:
You are the assignee for the bug.

More information about the kde-freebsd mailing list