[Bug 228116] [patch] x11/sddm: consolekit + PAM support

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228116

Tijl Coosemans <tijl at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193236|0                           |1
        is obsolete|                            |
 Attachment #193248|0                           |1
        is obsolete|                            |

--- Comment #6 from Tijl Coosemans <tijl at FreeBSD.org> ---
Created attachment 193430
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193430&action=edit
patch2

New patch with the following changes:
- Update to 0.17.0.
- Replace post-patch command for the sddm Xsession script with a patch so
$STARTUP is injected in the right place.  Also use dbus-run-session to start a
D-Bus session bus.  Otherwise libdbus will autolaunch the session bus on first
use and these autolaunched daemons don't always disappear when the session
closes.  Fix use of $@ in this script because "$@" is something special (see sh
man page).  This allows reverting ports r469242 which may not work with display
managers like gdm and lightdm that have built-in support for ConsoleKit.
- Remove unneeded USES=desktop-file-utils.  Reported by make stage-qa.
- Enable PAM support.
- Patch sddm.pam to be like /etc/pam.d/login.
- Patch sddm-autologin.pam to remove linuxisms and deny password changes.
- Patch sddm-greeter.pam to remove linuxisms.  Also, for the session facility
pam_unix.so is a no-op.
- Use %%PREFIX%% instead of /usr/local in xinitrc.desktop.
- Remove DesktopNames from xinitrc.desktop and patch sddm to leave
XDG_CURRENT_DESKTOP and XDG_SESSION_DESKTOP environment variables unset if
there's no DesktopNames.  These variables are used for OnlyShowIn and NotShowIn
in .desktop files so setting them to some arbitrary value messes up the desktop
started from ~/.xinitrc.
- Use @sample for sddm.conf.
- Patch the default configuration to leave InputMethod empty since
qtvirtualkeyboard does not appear to be supported by the included themes.  The
keyboard is drawn on top of the login screen and has to be clicked away (button
lower-right).
- Set the default theme and cursor theme to breeze, because sddm is most likely
used together with Plasma.  If they aren't available sddm falls back to a
compiled-in theme.
- Use post-patch instead of a patch to replace paths like /usr/bin/X with
/usr/local/bin/X.
- Add a patch to start console-kit-daemon from sddm, because there's no rc.d
script for that.  Add another patch to disable broken sddm ConsoleKit seat
management support because sddm assumes it has the same D-Bus interface as
logind which isn't true.
- Add an upstream patch to open sockets with SOCK_CLOEXEC.
- Run sddm-greeter via the session command (Xsession script) so it also gets X
resources and a ConsoleKit and D-Bus session.  The ConsoleKit session has its
session-class set to "user" instead of "greeter" because ck-launch-session
doesn't provide a way to change this.  ConsoleKit doesn't do anything with this
value though so it is believed to be harmless.  The XDG_SESSION_CLASS
environment variable does have the value "greeter".
- Improve the sddm rc.d script.  There's no pidfile so just use the standard
stop command.  Provide a default value for sddm_enable to silence a warning
from /etc/rc.subr.  There's no need to generate a configuration like with KDM
so remove that.  Use %%PREFIX%% and %%LOCALBASE%%.  Add a space after ! because
!command doesn't work.

-- 
You are receiving this mail because:
You are the assignee for the bug.