[Bug 223125] x11/kdelibs4: 'large' is no longer a valid msdosfs mount option in head after r319735

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223125

            Bug ID: 223125
           Summary: x11/kdelibs4: 'large' is no longer a valid msdosfs
                    mount option in head after r319735
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: kde at FreeBSD.org
          Reporter: avg at FreeBSD.org
             Flags: maintainer-feedback?(kde at FreeBSD.org)
          Assignee: kde at FreeBSD.org

x11/kdelibs4 has a patch, patch-solid_solid_backends_hal_halstorageaccess.cpp,
that adds 'large' option to msdosfs (aka vfat) mount command if that option is
reported as supported by hal.
The option was removed in head in commit base r319735 after completion of the
ino64 project.
hal still advertises 'large' as a valid option for all version of FreeBSD, see
bug #221709.
Conditionally removing that option in either hal or kde would work.


While I am here I would like to point out that
patch-solid_solid_backends_hal_halstorageaccess.cpp contains a bug.
It adds this line:
    if ( halOptions.contains("-L=") && (cType = getenv("LC_ALL")) || (cType =
getenv("LC_CTYPE")) || (cType = getenv("LANG")) )
it can be written in a compact form as
    if ( A && B || C || D )
which equivalent to
    if ( (A && B) || C || D )
but it really should be
    if ( A && (B || C || D) )

-- 
You are receiving this mail because:
You are the assignee for the bug.