[Bug 213993] math/kmplot: fix for lang/gcc5

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Nov 7 11:25:41 UTC 2016


Kenneth Salerno <kennethsalerno at yahoo.com> changed:

           What    |Removed                     |Added
 Attachment #176421|0                           |1
        is obsolete|                            |

--- Comment #7 from Kenneth Salerno <kennethsalerno at yahoo.com> ---
Created attachment 176715
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=176715&action=edit
view.cpp patch

Patch as requested. Tested successfully with __MAKE_CONF=/dev/null (clang) and

Note 1:
Original source was already including cmath - no change there

Note 2:
By adding std::, the existing lines become unnecessary
   #if defined(Q_CC_MINGW)
   using namespace std;

Note 3:
The reason clang++ does not need std:: to call isnan/isinf in scope is because
LLVM's /usr/include/c++/v1/cmath has "using ::isnan/::isinf" defined as well as
namespace std { }.

Either patch version will work, I just think my patch would have been easier to
maintain than touching view.cpp on so many lines that could get adjusted in
future releases and be a headache.

You are receiving this mail because:
You are the assignee for the bug.

More information about the kde-freebsd mailing list