[kde-freebsd] maintainer-feedback requested: [Bug 209799] misc/kdeedu4 kdeprefix removal too thorough

[bugzilla-noreply at freebsd.org]

groot at kde.org has reassigned Bugzilla Automation <bugzilla at FreeBSD.org>'s
request for maintainer-feedback to kde at FreeBSD.org:
Bug 209799: misc/kdeedu4 kdeprefix removal too thorough
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209799



--- Description ---
Created attachment 170733
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=170733&action=edit
Add blank USE_KDE4 to metaports that need it

In r415864, kdeprefix was removed from a whole lot of ports. In a few cases,
USE_KDE4= was removed entirely. This happened in some KDE metaports, not in all
of them. Many metaports have retained this line:

USE_KDE4=      # blank, needed to get KDE4_VERSION

Attached patch restores this line to three metaports that have lost it
entirely. There's two reasons for this:

 - consistency with the other metaports (less important)
 - there are some combinations of OPTIONS that can cause build failures because
KDE4_VERSION isn't defined

The latter issue can be illustrated as follows:

 - cd /usr/ports/misc/kdeedu4
 - make config
 - *uncheck* marble
 - portlint, or build

Because of marble (which is enabled by default), usually you get USE_KDE4 set
through this line in the Makefile:

MARBLE_USE=		KDE4=marble_run

When marble is unchecked, you get this (from portlint):


FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified
FATAL: Makefile: kdeedu- < kdeedu-4.14.3. Choose another PORTVERSION or bump
PORTEPOCH.