[kde-freebsd] [package - 93amd64-default][graphics/digikam-kde4] Failed for digikam-4.2.0_3, 2 in build

[Adriaan de Groot]

On Wednesday 23 March 2016 03:29:13 pkg-fallout at FreeBSD.org wrote:
> /wrkdirs/usr/ports/graphics/digikam-kde4/work/digikam-4.2.0/core/libs/dimg/f
> ilters/lens/lensfunfilter.cpp In file included from
> /wrkdirs/usr/ports/graphics/digikam-kde4/work/digikam-4.2.0/core/libs/dimg/
> filters/lens/lensfuniface.h:29, from
> /wrkdirs/usr/ports/graphics/digikam-kde4/work/digikam-4.2.0/core/libs/dimg/
> filters/lens/lensfunfilter.cpp:35:
> /usr/local/include/lensfun/lensfun.h:2506: error: template with C linkage
> /usr/local/include/lensfun/lensfun.h:2508: error: template with C linkage
> ***
> [digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/lens/lensfunfilter
> .o] Error code 1

This fallout occurs on 9.3 because of two things:

 - gcc from base doesn't like templates in an extern "C" { } block
   - clang in 10.1 doesn't mind
   - *possibly* gcc newer than 4.8.3 doesn't mind either
 - digikam stupidly puts extern "C" { #include <lensfun.h> } somewhere
   - lensfun itself is pretty careful with the linkage specifiers
   - i suspect that removing the extern "C" { } fixes this

Patch is attached -- but untesterd, since I don't have a 9.3 box available. 
Note also that the patch interferes with the file patch-git-r2ad23d-lensfun-fix 
as well. They would need to be merged.

Oh, and this may all be mooted by simply updating digikam to a much newer 
version from area51.

[ade]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lensfuniface.h.diff
Type: text/x-patch
Size: 324 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-freebsd/attachments/20160323/74f78426/attachment.bin>