[kde-freebsd] [Bug 205805] Mk/bsd.qt.mk: Update to 5.5.1

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205805

--- Comment #13 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
(In reply to Raphael Kubo da Costa from comment #12)
> I'll post some specific questions later.

OK, here we go. I hope you're still around to look at the comments, answer them
and hopefully start contributing to our experimental repositories in the
future.

First, some comments about things which have been fixed or implemented
differently in area51:

* Changes in USE_QT5 in many ports: this prompted me to take a look at the
situation. Indeed we were linking against many libraries without declaring
them. However, I chose to fix it differently, and instead of just adjusting
USE_QT5 I switched to building the Qt5 ports with -Wl,--as-needed so that the
final binaries only really link against the libraries that they actually need.
See http://src.mouf.net/area51/revision?rev=11818 and
http://src.mouf.net/area51/revision/?rev=11827.

* Adding USE_QT5=webchannel to webkit-qt5 doesn't make much sense, and adding
gstreamer-0.10 as a dependency is wrong. It must use GStreamer 1.0, like it
already does. Ditto for qt5-multimedia.

* Your change to qt5-printsupport's Makefile was partially right, see comment
#10 for all the required changes.

* I've net/libproxy as a dependency for net/qt5-network following your change.
It required some additional work:
http://src.mouf.net/area51/revision/?rev=11824

* The patches you've added to qt5-core are wrong, see their versions in area51.
Basically those things have all been fixed upstream, and importing the patches
from there is the right thing to do.

Now things that still need clarification from your patch:

* Why was patch-src__designer__src__src.pro removed from devel/qt5-uitools?

* Why the changes to the filterLibraryOptions calls in extrapatch-configure?

* I don't get why you added USES=gettext to several ports.

* I don't get why you need the post-patch changes you added to qt5-gui.

* I don't get any of the PCRE-related changes you've made to qt5-core and qt5.

* Why was patch-3rdparty__clucene__src__CLucene__search__FieldCacheImpl.cpp
removed from textproc/clucene-qt5? It was originally added because of bug
169872. It might not be needed anymore, but I need more context and
confirmation that you tested it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.