[Bug 214184] audio/amarok-kde4: fails to build with ffmpeg 3.x

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214184

Raphael Kubo da Costa <rakuco at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakuco at FreeBSD.org

--- Comment #9 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
(In reply to matthew from comment #8)
> I had thought MTP was not optional because there is no WITH_MTP switch in
> the CMakeLists.txt as there is for the other options.

There is, it's just added indirectly. Amarok's top-level CMakeLists.txt has
this:

    macro_optional_find_package(Mtp)

which is defined here:

https://cgit.kde.org/kdelibs.git/tree/cmake/modules/MacroOptionalFindPackage.cmake?h=KDE%2F4.14

As the comment there says, "this macro is a combination of OPTION() and
FIND_PACKAGE(), it works like FIND_PACKAGE(), but additionally it automatically
creates an option name WITH_<name>, which can be disabled via the cmake GUI or
via -DWITH_<name>=OFF", so WITH_Mtp should work as expected -- in fact, I've
built the port on Poudriere with the MTP option disabled and the logs show
src/core-impl/collections/mtpcollection is not being built and nothing is
linking against libmtp.

If you feel like something still needs to be patched, please file a new PR so
we don't mix FFMPEG 3 support with other adjustments to the port, especially
now that this bug has already been closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.