[kde-freebsd] [Bug 203793] Fix devel/cmake-modules so it prefers "c++" over "CC" for compiling C++ programs

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203793

--- Comment #4 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
(In reply to Dimitry Andric from comment #3)
> (In reply to Raphael Kubo da Costa from comment #2)
> > I think I'm still missing some context. Bug 200475 was about removing CC; if
> > CMake worked fine in that case, which problem is it solving here (ie. with
> > CC still present)? Is there a plan to make CC != c++?
> 
> The plan is to remove /usr/bin/CC in head.  However, on older branches,
> /usr/bin/CC will still exist.  In my opinion, cmake should prefer calling
> "c++" over "CC", if the former is available, that is all.

I see. But is there any downside to using CC if it's available? I'm trying to
think from an upstream perspective, to whom a commit changing the order with no
effects might seem unnecessary.

> > Also, instead of changing CMakeDetermineCXXCompiler.cmake, doesn't adding a
> > Modules/Platform/FreeBSD-CXX.cmake similar to the Linux one also solve the
> > problem you are trying to fix?
> 
> Yes, but why would that be better than just fixing the C++ compiler
> determination for all platforms?

I'm not sure if there's anything to be fixed in the first place, especially if
you send it upstream and this changes behavior in all platforms CMake supports.
I'm again assuming this is something upstreamable that either you or I will
send to the appropriate list.

-- 
You are receiving this mail because:
You are the assignee for the bug.