[kde-freebsd] [SVN Commit] area51/QT

[Max Brazhnikov]

On Tue, 24 Mar 2015 09:35:21 -0700 (PDT) Tobias Berner wrote:
> SVN commit 10648 by tcberner:
> 
> Add a new port www/qt5-webchannel

Welcome Tobias!
A couple of notes for your first commit (consider it as a opportunity for the second commit :)

> Index: www/qt5-webchannel/Makefile
> ===================================================================
> --- www/qt5-webchannel/Makefile	(revision 0)
> +++ www/qt5-webchannel/Makefile	(revision 10648)
> @@ -0,0 +1,16 @@
> +# $FreeBSD$
> +
> +PORTNAME=	webchannel
> +DISTVERSION=	${QT5_VERSION}
> +CATEGORIES=	www
> +PKGNAMEPREFIX=	qt5-
> +
> +MAINTAINER=	kde at FreeBSD.org
> +COMMENT=	Qt 5 library for integration of C++/QML with HTML/js clients.

COMMENT should end without a period, and without trailing space.

> Index: Mk/bsd.qt.mk
> ===================================================================
> --- Mk/bsd.qt.mk	(revision 10647)
> +++ Mk/bsd.qt.mk	(revision 10648)
> @@ -298,7 +298,7 @@
> 
>  _USE_QT5_ONLY=	buildtools concurrent core graphicaleffects \
>  
>  				paths phonon4 phonon4-gst printsupport qdbus qdoc qev qml quick \
> 
> -				quickcontrols serialport uitools widgets x11extras
> +				quickcontrols serialport uitools webchannel widgets x11extras
> 
>  accessible_PORT=	accessibility/${_QT_RELNAME}-accessible
>  accessible_PATH=	${QT_PLUGINDIR}/accessible/libqtaccessiblewidgets.so
> 
> @@ -515,6 +515,9 @@
> 
>  uitools_PORT=		devel/${_QT_RELNAME}-uitools
>  uitools_PATH=		${QT_LIBDIR}/libQt${_QT_LIBVER}UiTools.a
> 
> +webchannel_PORT=	www/qt5-webchannel
> +webchannel_PATH=	${QT_LIBDIR}/libQt5WebChannel.so

Please use _QT_RELNAME/_QT_LIBVER here instead of qt5/Qt5 similar to the others.

Max