[kde-freebsd] [patch] devel/qca: update to 2.1.0
Tijl Coosemans
tijl at FreeBSD.org
Mon Jan 12 16:42:08 UTC 2015
On Mon, 12 Jan 2015 13:54:51 -0200 Raphael Kubo da Costa <rakuco at FreeBSD.org> wrote:
> Tijl Coosemans <tijl at FreeBSD.org> writes:
>> On Mon, 12 Jan 2015 10:12:18 -0200 Raphael Kubo da Costa <rakuco at FreeBSD.org> wrote:
>>> Tijl Coosemans <tijl at FreeBSD.org> writes:
>>>> The attached patch updates devel/qca to 2.1.0. This brings quite a
>>>> number of changes, e.g. the port now uses cmake instead of qmake and
>>>> QCA plugins are no longer separate so the patch also deletes
>>>> security/qca-* and adjusts all ports that depend on it.
>>>
>>> This looks great, thanks a lot for working on this. The only part I did
>>> not understand was devel/qca/files/patch-CMakeLists.txt: why is it
>>> necessary?
>>
>> It uses a bundled set of root certificates without that patch. I think
>> it's better to use the certificates from security/ca_root_nss because
>> it's kept more up to date.
>
> That part is clear, my question was why the patch was needed since the
> functionality to read the environment variable was already there.
>
> And then I tested it here and found out the upstream code is broken :)
> I'll send it upstream, meanwhile it would be good if you could add a
> short explanation to the top of the patch saying why it is needed.
Sure, committed in r376838.
More information about the kde-freebsd
mailing list