[kde-freebsd] [Bug 194088] www/webkit-qt5 needs uninstall before build

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194088

--- Comment #5 from commit-hook at freebsd.org ---
A commit references this bug:

Author: rakuco
Date: Mon Dec 28 18:51:42 UTC 2015
New revision: 404694
URL: https://svnweb.freebsd.org/changeset/ports/404694

Log:
  Make sure ${WRKSRC}/lib is passed before /usr/local/lib when linking.

  This is another shot at fixing the linkage problems that have plagued our
  users particularly when upgrading from Qt 5.x to 5.(x+1). Quick recap: in
  Qt5, qmake will by default pass QMAKE_LIBDIR to the linker before other
  directories such as ${WRKSRC}/lib, which is where the port's libraries are
  built. When a user is upgrading Qt, we can end up with the following linker
  line:
    c++ -o SomeBinary -lfoo1 -L/usr/local/lib -L${WRKSRC}/lib -lfoo2 -lfoo3
  If libfoo2.so is being built by the port and an older version is currently
  installed on the system, /usr/local/lib/libfoo2.so will be picked up instead
  of the newly-built ${WRKSRC}/lib/libfoo2.so. At best things just work, at
  worst SomeBinary needs some new symbol that is not present in the old
  libfoo2.so and linking fails. Case in point: bug 198720.

  The previous approach, adopted when fixing bug 194088, was to stop setting
  QMAKE_{INC,LIB}DIR in the FreeBSD mkspecs and set the CPATH and LIBRARY_PATH
  environment variables in Uses/qmake.mk. This way we just did not pass
  -L/usr/local/lib to the linker at all and things mostly worked. However,
  people using Qt to build their own software without the ports tree were out
  of luck, as they would then need need to deal with passing
  /usr/local/{include,lib} to the compiler/linker themselves (bug 195105). Not
  only that, but if a dependency mentioned /usr/local/lib we would still have
  problems anyway (in bug 198720, the GStreamer pkg-config files contain
  -L/usr/local/lib, for example).

  We now solve the issue by setting the QMAKE_LIBDIR_FLAGS variable in
  .qmake.cache to ${WRKSRC}/lib instead. qmake appends the value of
  QMAKE_LIBDIR to QMAKE_LIBDIR_FLAGS, so we are always sure -L${WRKSRC}/lib
  will come before -L/usr/local/lib in the linker options. Moreover, qmake is
  smart enough to automatically call sed(1) and remove references to
  ${WRKSRC}/lib from .prl and .pc files when installing them.

  PR:           194088
  PR:           195105
  PR:           198720
  MFH:          2015Q4

Changes:
  head/Mk/Uses/qmake.mk
  head/Mk/bsd.qt.mk
  head/devel/qmake5/Makefile
  head/devel/qmake5/files/patch-mkspecs__common__freebsd.conf

-- 
You are receiving this mail because:
You are the assignee for the bug.