[kde-freebsd] maintainer-feedback requested: [Bug 205339] [PATCH] x11/kdelibs4: add options

[bugzilla-noreply at freebsd.org]

matthew at reztek.cz has reassigned Bugzilla Automation <bugzilla at FreeBSD.org>'s
request for maintainer-feedback to kde at FreeBSD.org:
Bug 205339: [PATCH] x11/kdelibs4: add options
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205339



--- Description ---
Created attachment 164267
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=164267&action=edit
add options to x11/kdelibs4

x11/kdelibs4 has had a rather odd dependency and pkg-message for quite some
time; it unconditionally depends on hupnp in order to build the UPnP backend
for Solid, but there is also a patch which disables that backend, and the
pkg-message notes it is known to cause instability and so is disabled but can
be enabled via an environment variable. WTF?! Why build something just to leave
it disabled, and if it's known to cause instability why is it being built at
all?

Restore some sanity to this port with a couple options: AVAHI and UPNP. The
UPNP option replaces the hack with a normal option, which allows the patch and
pkg-message to be removed. The AVAHI option simply makes that dependency
optional since it is not required for KDE. The defaults of the new options are
in keeping with past behavior, AVAHI is on as it was, UPNP is off because is is
known unstable and the functionality was previously disabled. So, the only
functional change is to drop a useless dependency by default.