[kde-freebsd] What's going on with the distfiles for the graphics/kipi-plugin-* ports?

[Peter Wemm]

On Monday 26 May 2014 21:35:05 Baptiste Daroussin wrote:
> On Mon, May 26, 2014 at 12:11:20PM -0700, Peter Wemm wrote:
> > This is causing a bit of pain and suffereing for the distfile fetcher:
> > 
> > ports/graphics/kipi-plugin-facebook # make -V DISTFILES
> > digikam-3.5.0.tar.bz2
> > 
> > ports/graphics/kipi-plugin-facebook # make -DNO_BUILD -V DISTFILES
> > kipi-plugin-facebook-3.5.0.tar.gz
> > 
> > ie: if NO_BUILD is set, it uses different, unlisted distfiles.  These are
> > NOT in distfinfo anywhere.
> > 
> > Even more bizzare:
> > 
> > ports/graphics/kipi-plugin-facebook # make checksum
> > ===>  License GPLv2 accepted by the user
> > ===>   kipi-plugin-facebook-3.5.0_1 depends on file: /usr/local/sbin/pkg -
> > found
> > => digikam-3.5.0.tar.bz2 doesn't seem to exist in /usr/ports/distfiles/.
> > => Attempting to fetch
> > http://download.kde.org/stable/digikam/digikam-3.5.0.tar.bz2
> > digikam-3.5.0.tar.bz2                         100% of   62 MB 3880 kBps
> > 00m16s ===> Fetching all distfiles required by
> > kipi-plugin-facebook-3.5.0_1 for building
> > => SHA256 Checksum OK for digikam-3.5.0.tar.bz2.
> > 
> > ie: it works just fine as a 'make checksum',  but:
> > 
> > ports/graphics/kipi-plugin-facebook # make -DNO_BUILD checksum
> > ===>   kipi-plugin-facebook-3.5.0_1 depends on file: /usr/local/sbin/pkg -
> > found
> > => kipi-plugin-facebook-3.5.0.tar.gz doesn't seem to exist in
> > /usr/ports/distfiles/.
> > => Attempting to fetch
> > http://download.kde.org/stable/digikam/kipi-plugin-facebook-3.5.0.tar.gz
> > fetch:
> > http://download.kde.org/stable/digikam/kipi-plugin-facebook-3.5.0.tar.gz:
> > Not Found => Attempting to fetch
> > ftp://ftp.gtlib.gatech.edu/pub/kde/stable/digikam/kipi-plugin-facebook-3.
> > 5.0.tar.gz fetch:
> > ftp://ftp.gtlib.gatech.edu/pub/kde/stable/digikam/kipi-plugin-facebook-3.
> > 5.0.tar.gz: File unavailable (e.g., file not found, no access) =>
> > Attempting to fetch
> > ftp://ftp.informatik.hu-berlin.de/pub/Mirrors/ftp.kde.org/stable/digikam/
> > kipi-plugin-facebook-3.5.0.tar.gz fetch:
> > ftp://ftp.informatik.hu-berlin.de/pub/Mirrors/ftp.kde.org/stable/digikam/
> > kipi-plugin-facebook-3.5.0.tar.gz: File unavailable (e.g., file not found,
> > no access) => Attempting to fetch
> > http://ftp.gtlib.gatech.edu/pub/kde/stable/digikam/kipi-plugin-facebook-3.
> > 5.0.tar.gz [....]
> > 
> > ie: it spams all 30+ KDE mirrors for a file that doesn't exist.  What on
> > earth is going on?
> > 
> > Why does this exist?
> > 
> > At the very least, could we move it a bit?  eg:
> > 
> > ports-head/graphics/digikam-kde4 % svn diff
> > Index: Makefile.common
> > ===================================================================
> > --- Makefile.common     (revision 355424)
> > +++ Makefile.common     (working copy)
> > @@ -110,7 +110,6 @@
> > 
> >  # wallpaper_DESC=      Set image as background on desktop
> >  yandexfotki_DESC=      Export images to Yandex web service
> > 
> > -.if !defined(NO_BUILD)
> > 
> >  DISTNAME=      digikam-${DIGIKAM_VER}
> >  
> >  LICENSE?=      GPLv2
> > 
> > @@ -124,6 +123,7 @@
> > 
> >  DISTINFO_FILE= ${.CURDIR}/../../graphics/digikam-kde4/distinfo
> > 
> > +.if !defined(NO_BUILD)
> > 
> >  . if defined(KIPI_PLUGIN)
> >  CONFLICTS_INSTALL=     kipi-plugins-2.*
> > 
> > Granted, I don't understand the finer points of this stuff, but it seems
> > like NO_BUILD is the wrong knob here.
> 
> Problem is in digikam-kde4/Makefile.common, it should not use NO_BUILD to
> differenciate the distfiles
> 
> regards,
> Bapt

Yep, that was the gist of the patch I pasted above was to try and get the 
distfile fetcher to work better.

NO_BUILD is clearly the wrong knob, but moving it down a bit in Makefile.common 
seemed to have reduced the damage.  It still needs attention.

[Replying to add kde@ to the cc: list]
-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com; KI6FJV
UTF-8: for when a ' just won\342\200\231t do.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-freebsd/attachments/20140526/d5f8003f/attachment.sig>