[kde-freebsd] ports/186707: [patch] devel/qt4-corelib: fix iconv detection
makc at freebsd.org
Sun Mar 9 16:50:02 UTC 2014
The following reply was made to PR ports/186707; it has been noted by GNATS.
From: Max Brazhnikov <makc at freebsd.org>
To: Tijl Coosemans <tijl at freebsd.org>
Cc: bug-followup at freebsd.org
Subject: Re: ports/186707: [patch] devel/qt4-corelib: fix iconv detection
Date: Sun, 09 Mar 2014 16:37:51 +0000
On Thu, 06 Mar 2014 23:12:06 +0100 Tijl Coosemans wrote:
> On Wed, 05 Mar 2014 06:08:43 +0000 Max Brazhnikov wrote:
> > On Tue, 04 Mar 2014 23:12:09 +0100 Tijl Coosemans wrote:
> >> On Tue, 04 Mar 2014 06:45:58 +0000 Max Brazhnikov wrote:
> >>> Is it enough to patch single qt4-corelib port? Shouldn't the patch be
> >>> shared among other Qt4 ports?
> >> You mean to let other Qt ports respect CXXFLAGS during configure or
> >> to fix iconv issues?
> > All Qt ports are built from the same tarball, other qt4 ports could pick
> > up ports libiconv again, if the fix is not global.
> I grepped the full tarball for iconv\.h and only these cases came up:
> config.tests/unix/gnu-libiconv/gnu-libiconv.cpp:#include <iconv.h>
> config.tests/unix/iconv/iconv.cpp:#include <iconv.h>
> src/corelib/codecs/qiconvcodec_p.h:#include <iconv.h>
> The first two are configure tests and the last one is a private header
> from corelib. That header is included from these two .cpp files:
> src/corelib/codecs/qtextcodec.cpp:# include "qiconvcodec_p.h"
> src/corelib/codecs/qiconvcodec.cpp:#include "qiconvcodec_p.h"
> These essentially wrap the iconv API, so I think the use of iconv is
> really restricted to corelib and for me the patch is good enough.
> It would be nice to fix all qt4 ports so they all respect CXXFLAGS
> during configure (build phase is already ok), but I'm not sure where
> in bsd.qt.mk a REINPLACE_CMD or something can be added to accomplish
You can use common EXTRA_PATCHES defined in bsd.qt.mk for Qt ports,
the patches are stored in devel/qt4.
More information about the kde-freebsd