[kde-freebsd] Update Amarok to 2.8.0
Raphael Kubo da Costa
rakuco at FreeBSD.org
Fri Jul 18 12:08:54 UTC 2014
Kris Moore <kris at pcbsd.org> writes:
> Just a FYI, we updated audio/amarok-kde4 port to 2.8.0 today. Attached
> is patch, if you would like to take a look.
>
> I can commit this to FreeBSD ports tree if it looks ok to you.
I'm not at home at the moment for a more thorough check, but from a
quick glace it's mostly OK. My only reservations are with these two
bits:
> +CFLAGS+= -D__STDC_CONSTANT_MACROS
This looks like the wrong place to fix this: libav should have defined
that, or it should come from kdelibs itself, or if everything else fails
Amarok needs to define it, but then I'd prefer an actual patch in files/
changing only the required files. I'll check later if this should come
from another port.
> -OPTIONS_DEFAULT=IPOD MP3TUNES MTP
> +OPTIONS_DEFAULT=AMAZON IPOD MP3TUNES MTP
Any particular reason for this change?
More information about the kde-freebsd
mailing list