[kde-freebsd] Qt4 ports are too bloated: part 1 (devel/qt4-designer)

[Alexey Dokuchaev]

Hi there dear KDE people,

Most of Qt4 ports allow to selectively disable some heavy parts, e.g.
phonon, webkit, gstreamer, etc.  However, our Qt4 framework does not allow
to optionally disable those bits.  Previously, I've already raised this
bug about qt4-webkit, now it's time for other Qt4 ports.

Please consider attached patch to make phonon optional in qt4-designer,
yet still on by default.  Qt4 is nice framework, but lots of people do
not need any of its multimedia features.  Please allow us to disable them.

./danfe
-------------- next part --------------
Index: Mk/bsd.qt.mk
===================================================================
--- Mk/bsd.qt.mk	(revision 332253)
+++ Mk/bsd.qt.mk	(working copy)
@@ -63,7 +63,7 @@
 		-sysconfdir ${PREFIX}/etc/xdg \
 		-examplesdir ${PREFIX}/share/examples/qt4/examples \
 		-demosdir ${PREFIX}/share/examples/qt4/demos \
-		-phonon -no-phonon-backend
+		-no-phonon-backend
 
 PLIST_SUB+=	SHLIB_VER=${QT4_VERSION:C/-.*//} \
 		SHLIB_SHVER=${QT4_VERSION:R}
Index: devel/qt4-designer/Makefile
===================================================================
--- devel/qt4-designer/Makefile	(revision 332253)
+++ devel/qt4-designer/Makefile	(working copy)
@@ -1,4 +1,4 @@
-# Created by: lofi at FreeBSD.org
+# Created by: Michael Nottebrock <lofi at FreeBSD.org>
 # $FreeBSD$
 
 PORTNAME=	designer
@@ -7,17 +7,17 @@
 PKGNAMEPREFIX=	qt4-
 
 MAINTAINER=	kde at FreeBSD.org
-COMMENT=	Qt ui editor
+COMMENT=	Qt UI editor
 
 USE_QT4=	qmake_build moc_build rcc_build uic_build assistant_run \
 		qt3support corelib declarative gui network script sql xml \
-		webkit phonon
+		webkit
 QT_NONSTANDARD=	yes
 QT_DIST=	yes
 
 HAS_CONFIGURE=	yes
-#Try to fix linking when previous version is installed
-CONFIGURE_ARGS+=	-L${WRKSRC}/lib
+# Try to fix linking when previous version is installed
+CONFIGURE_ARGS=	-L${WRKSRC}/lib
 USE_LDCONFIG=	${PREFIX}/lib/qt4
 
 ALL_TARGET=	first
@@ -44,6 +44,14 @@
 
 EXTRA_PATCHES+=	${.CURDIR}/../../devel/qt4/files/patch-configure
 
+OPTIONS_DEFINE=	PHONON
+OPTIONS_DEFAULT=	PHONON
+PHONON_DESC=	Phonon multimedia framework support
+
+PHONON_USE=	QT4=phonon
+PHONON_CONFIGURE_ON=	-phonon
+PHONON_CONFIGURE_OFF=	-no-phonon
+
 pre-configure:
 	${REINPLACE_CMD} -e 's|^TARGET.*|TARGET=designer-qt4|g' \
 		${BUILD_WRKSRC}/src/${PORTNAME}/${PORTNAME}.pro