[kde-freebsd] Fixing devel/qt4-corelib to build with clang

Raphael Kubo da Costa rakuco at FreeBSD.org
Thu May 9 22:56:16 UTC 2013


Dimitry Andric <dim at FreeBSD.org> writes:

> On 2013-05-08 15:00, Raphael Kubo da Costa wrote:
>> Dimitry Andric <dimitry at andric.com> writes:
>>> On 2013-05-08 13:18, Raphael Kubo da Costa wrote:
>>>> This still looks weird to me: QT_HAVE_3DNOW should only be defined if
>>>> the test in config.tests/unix/3dnow/3dnow.cpp passes. It's supposed to
>>>> fail to build with clang-i486 just like qsimd.cpp.
>>>
>>> Those tests do not fail, because during the tests, the appropriate
>>> parameters are passed, e.g. -m3dnow, -msse and so on.
>>
>> Ah, right, thanks for the clarification.
>>
>> This indeed looks like a bug in Qt that is only present in the 4.x
>> series. Would you mind contributing that patch upstream to Qt itself? I
>> can also do that if you prefer.
>
> If they already know you, it might be quicker if you submit it. :)

Done: https://codereview.qt-project.org/#change,55800


More information about the kde-freebsd mailing list