[kde-freebsd] port options are not saved in some ports

[Baptiste Daroussin]

On Mon, Jul 08, 2013 at 09:05:58AM +0300, Andriy Gapon wrote:
> 
> It seems that port options do not "stick" in the following ports:
> ukrainian/kde4-l10n
> russian/kde4-l10n
> 
> Could you please take a look?
> 
> -- 
> Andriy Gapon

That is because misc/kde4-l10n/files/bsd.l10n.mk is totally wrong

it does


...
.include <bsd.port.pre.mk>
...
.include <bsd.port.options.mk>
...
.include <bsd.port.post.mk>



First the right order in that case should be:

...
.include <bsd.port.options.mk>
...
.include <bsd.port.pre.mk>
...
.include <bsd.port.post.mk>


Second in that case (kde)
The pre.mk/post.mk can be removed just keeping the options.mk

and given that we now have the helpers options.mk can also be removed.

The check for variables in OPTIONS_DEFINE is also useless (already done by the
framework)

defining OPTIONS_DEFINE and OPTIONS_DEFAULT to some empty values is also
useless.

http://people.freebsd.org/~bapt/kde.diff

now just replace bsd.port.post.mk in russian/kde4-l10n/Makefile by bsd.port.mk
and everything will work properly again.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-freebsd/attachments/20130708/71a141b9/attachment.sig>