[kde-freebsd] [SVN Commit] area51/PORTS/net-p2p

[Max Brazhnikov]

On Mon, 21 Jan 2013 00:21:52 +0100, Schaich Alonso wrote:
> On 2013-01-20 (Sunday) 22:55:39 you wrote:
> > Hi Alonso,
> > 
> > On Sun, 20 Jan 2013 21:35:14 GMT, Alonso Schaic wrote:
> > > SVN commit 8950 by aschai:
> > > 
> > > Update ktorrent to 3.0.1.
> > 
> > I think you mean 4.3.1 :)
> 
> Yes :D
> I guess I got confused by these two packages being versioned 5.0.1 and 15.0.0 
> in the library naming :D
> 
> > 
> > > - Removed stale patches
> > > - Added security/libgcrypt to libktorrent LIBDEPENDS
> > > - Regenerated pkg-plist files
> > 
> > You need to remove PORTREVISION whenever port gets updated.
> > Usually we don't set PORTREVISION in area51 at all, since most of the time
> > ports are never than in the portstree.
> > 
> > Your plist changes have to be reverted. First, we don't record common
> > directories from kdehier4. Second, plist must be sorted as described in
> > Porters handbook: files are arranged in alphabetic order, directories in
> > reverse order. The sorting process is a little bit tricky if plist uses
> > substitutions: you need to sort raw files list and then replace required
> > strings by according macros from PLIST_SUB.
> > 
> > >  M  +2 -2      ktorrent/Makefile
> > >  M  +2 -2      ktorrent/distinfo
> > >  D             ktorrent/files/patch-ktorrent__core.cpp
> > >  M  +171 -21   ktorrent/pkg-plist
> > >  M  +4 -3      libktorrent/Makefile
> > >  M  +2 -2      libktorrent/distinfo
> > >  D             libktorrent/files (directory)
> > >  M  +133 -16   libktorrent/pkg-plist
> > 
> > Cheers,
> > Max
> 
> Reverted the pkg-plist files. I had them generated by modifying 
> CMAKE_INSTALL_PREFIX to a empty path in order to record everything created by 
> the installation procedure instead of going the handbook procedure.

Handbook procedure works fine for ports that respect prefix, ktorrent belongs
to this majority.

> The 
> reverted/original pkg-plist files both have
> > @dirrmtry share/locale/si/LC_MESSAGES
> > @dirrmtry share/locale/si
> which are shared with at least misc/kde4-l10n-si (while they don't try to 
> remove translation paths for other languages)

We move directories to kdehier, if they are widely used. In principle, we can
add locale directories from all kde4-l10n ports to kdehier.

Max