[kde-freebsd] devel/smokekde

[Schaich Alonso]

On Sun, 18 Aug 2013 23:20:42 +0300
Raphael Kubo da Costa <rakuco at FreeBSD.org> wrote:

> Raphael Kubo da Costa <rakuco at FreeBSD.org> writes:
> 
> > Schaich Alonso <alonsoschaich at fastmail.fm> writes:
> >
> >> Hello
> >>
> >> devel/smokekde seems to use the -fno-exceptions compiler switch to
> >> disable C++ exceptions, while at the same time it refers to some inline
> >> code of akonadi that uses exceptions
> >> (${KDEPREFIX}/include/akonadi/itempayloadinternals_p.h:164 for example),
> >> which therefore fails to build. The way I see it we can either remove the
> >> -fno-exception flag and eventually have an exception be thrown into non-C
> >> ++ code (undefined behaviour), or remove akonadi wrapper generation from
> >> smokekde, which eventually will become troublesome if some smokekde
> >> consumer (other ports or other parts of smokekde as well) attempts to
> >> use it.
> >
> > I thought I had changed our patch to FindKDE4Internals.cmake in kdelibs4
> > to pass -fdelayed-template-parsing, but apparently I only committed
> > r9299. That's still weird, because r9299 removed "-fno-exceptions" from
> > the default C++ flags and smokekde itself does not explicitly change
> > those flags.
> >
> > My guess is that our patch is outdated -- there was a clang-related
> > commit that got into 4.11.0 that made the GCC block be shared with
> > clang, so we're first getting the -fno-exception thing and later
> > repeating some flags in our own clang block in FindKDE4Internal.cmake.
> >
> > If that's the case, I suppose there are at least a lot of unrecognized
> > compiler flags errors/warnings in your build logs.
> 
> Fixed in area51 r9455: it's basically what I did in
> https://git.reviewboard.kde.org/r/112137/ and want to get into 4.11.1.

Nice patch. And nice to have it in upstream.

There's a number of other ports that I patched in a similar way, I'll remove
those patches.

Alonso