[kde-freebsd] INSTALLS_ICONS and qt4 software

[Oliver Heesakkers]

Op zo 22 jan 2012 14:34:18 schreef Max Brazhnikov:
(...) 
> Yes, your are right, KDE4 ports don't need INSTALLS_ICONS.
> 
> > When a Gnome-user installs this port, would he/she require
> > INSTALLS_ICONS
> > to have the icon show up?
> 
> Probably yes.
> 
> > If so, is there a standard way for the ports Makefile to check for the
> > existence or use of Gnome so I can optionally set INSTALLS_ICONS? I
> > think
> > it's overkill to make an actual OPTIONS= line for it.
> 
> You can add WITH_GNOME knob, or do nothing.
> 
> Actually I don't understand why ports should care about Gnome's icons cache.
> If Gnome desktop need up-to-date icons cache to work, it should take
> responsibility on updating the cache (like other desktops do :)
> 
> Alternatively, INSTALLS_ICONS may be changed to do its work only if Gnome is
> installed. But that's up to gnome@ team to decide.
> 


Thanks for getting back to me. I submitted a patch[1] last friday which does 
this:

.if exists(${LOCALBASE}/bin/gnome-session)
INSTALLS_ICONS=        yes
.endif

It was committed without questions or remarks

[1]. http://www.freebsd.org/cgi/query-pr.cgi?pr=164344