[kde-freebsd] Re: Amarok fails to start after package rebuild

[Jan Henrik Sylvester]

On 03/22/2011 16:15, Raphael Kubo da Costa wrote:
> Jan Henrik Sylvester<me at janh.de>  writes:
>
>> On 03/22/2011 15:23, Raphael Kubo da Costa wrote:
> This commit in Amarok's master:
>
> http://quickgit.kde.org/?p=amarok.git&a=commitdiff&h=c62bb9a2ba514165e8e430302aafb19bfb95b9ce
>
> My idea is to make sure your patch also works with the upcoming
> versions, otherwise we will have trouble in the next release again.
>
> And in case the patch makes sense, it'd be good to have it upstream
> instead of keeping it in ports, so that's one more reason to make sure
> it works with master.

I am not sure, if upstream will take that patch, as it is only necessary 
for mysql 5.5 installations that are not patched. AFAIR, Fedora for 
example has the mysql bug patched. The patch should not cause 
regressions with configurations that do not have the mysql bug, though.

Anyway, I can confirm that the patch is still needed after applying the 
git change you mentioned to amarok 2.4.0. Of course, it needs to be 
modified to apply.

The first of the two files attached patches that file in amarok to the 
git master version, the second file is the workaround for the mysql bug.

If you put both in audio/amarok-kde4/files/, the current official 
FreeBSD port (2.4.0) works again with the current mysql port (5.5.10). 
The overall effect is exactly the same is with my earlier patch.

When the amarok port is updated, the first patch does not apply anymore 
and can be deleted, but the second one should remain, as long as mysql 
does not fix the bug and amarok does not incorporate the/a workaround.

Cheers,
Jan Henrik
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-git-src_core-impl_collections_db_sql_mysqlecollection_MySqlEmbeddedStorage.cpp
Url: http://mail.kde.org/pipermail/kde-freebsd/attachments/20110322/875bac2a/attachment.bat 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-src_core-impl_collections_db_sql_mysqlecollection_MySqlEmbeddedStorage.cpp
Url: http://mail.kde.org/pipermail/kde-freebsd/attachments/20110322/875bac2a/attachment-0001.bat