[kde-freebsd] Re: ports/156901: [patch] devel/cmake breaks with CC containing spaces

[Dominic Fandrey]

The following reply was made to PR ports/156901; it has been noted by GNATS.

From: Dominic Fandrey <kamikaze at bsdforen.de>
To: bug-followup at FreeBSD.org, kamikaze at bsdforen.de
Cc:  
Subject: Re: ports/156901: [patch] devel/cmake breaks with CC containing spaces
Date: Wed, 13 Jul 2011 10:38:48 +0200

 This is a multi-part message in MIME format.
 --------------010702010605020601030305
 Content-Type: text/plain; charset=ascii
 Content-Transfer-Encoding: 7bit
 
 After running into some issues with tinderd I added MP safe locking,
 applied the patch in ports/158722 to the ports trees, because
 gobject-introspection was such a PITA and started over.
 
 Currently 848 of 1260 queue entries have been processed. So far two
 regressions manifested:
 	games/opensonic
 	graphics/rawtherapee
 
 I have attached patches for both.
 
 So far exactly 100 cases have improved due to the cmake patch.
 
 -- 
 A: Because it fouls the order in which people normally read text.
 Q: Why is top-posting such a bad thing?
 A: Top-posting.
 Q: What is the most annoying thing on usenet and in e-mail? 
 
 --------------010702010605020601030305
 Content-Type: text/plain;
  name="patch-ports-games-opensonic.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="patch-ports-games-opensonic.txt"
 
 diff -Nur opensonic.orig/Makefile opensonic/Makefile
 --- opensonic.orig/Makefile	2011-07-13 09:06:44.000000000 +0200
 +++ opensonic/Makefile	2011-07-13 09:39:05.000000000 +0200
 @@ -23,10 +23,10 @@
  		"false"
  
  USE_CMAKE=	yes
 -CMAKE_ENV+=	OPENSNC_ALLEGRO_LIBS="`allegro-config --libs`" OPENSNC_ALLEGRO_VERSION="`allegro-config --version`"
 +CONFIGURE_ENV+=	OPENSNC_ALLEGRO_LIBS="`allegro-config --libs`" OPENSNC_ALLEGRO_VERSION="`allegro-config --version`"
  
  CFLAGS+=	-I${LOCALBASE}/include
 -MAKE_ENV+=	CFLAGS="${CFLAGS}"
 +MAKE_JOBS_SAFE=	yes
  
  BUILD_DEPENDS+=	${LOCALBASE}/lib/libaldmb.a:${PORTSDIR}/audio/dumb-allegro \
  		alpng>=1.3:${PORTSDIR}/graphics/alpng
 
 --------------010702010605020601030305
 Content-Type: text/plain;
  name="patch-ports-graphics-rawtherapee.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="patch-ports-graphics-rawtherapee.txt"
 
 diff -Nur rawtherapee.orig/Makefile rawtherapee/Makefile
 --- rawtherapee.orig/Makefile	2011-07-13 09:28:50.000000000 +0200
 +++ rawtherapee/Makefile	2011-07-13 09:37:06.000000000 +0200
 @@ -28,10 +28,9 @@
  USE_LDCONFIG=	yes
  CFLAGS+=	-I${LOCALBASE}/include -fPIC ${PTHREAD_CFLAGS}
  LDFLAGS+=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 -CMAKE_ENV=	CFLAGS="${CFLAGS}" \
 -		LDFLAGS="${LDFLAGS}"
  SUB_FILES=	rawtherapee
  SUB_LIST=	RTDIR="${RTDIR}"
 +MAKE_JOBS_SAFE=	yes
  
  WRKSRC=		${WRKDIR}/RawTherapee${PORTVERSION:S,.,,g}
  RTDIR=	${PREFIX}/libdata/${PORTNAME}
 
 --------------010702010605020601030305--