[kde-freebsd] Re: [SVN Commit] area51/KDE/sysutils/ksysguardd

[Raphael Kubo da Costa]

David Naylor <naylor.b.david at gmail.com> writes:

> On Saturday 23 April 2011 17:28:03 Raphael Kubo da Costa wrote:
>> David Naylor <naylor.b.david at gmail.com> writes:
>> > On Saturday 23 April 2011 01:40:24 Raphael Kubo da Costa wrote:
>> >> David Bruce Naylor <naylor.b.david at gmail.com> writes:
>> >> > SVN commit 7200 by DragonSA:
>> >> > 
>> >> > Update ksysguardd and fix bug (causes segfault).
>> >> > 
>> >> > ksysguardd no longer uses libkvm so does not need g+s or grp=kmem
>> >> > and ksysguardd can now run as a regular (unprivileged) user.
>> >> > 
>> >> > An error in calculating MSI offsets resulted in the last regular
>> >> > interrupt being included as a MSI interrupt and a buffer underrun,
>> >> > causing a segfault.  This has been fixed.
>> >> > 
>> >> > @avilla: please push this commit to ports.
>> >> 
>> >> Is this upstream too?
>> > 
>> > I have not upstreamed the patch yet, but will contact John Tapsell soon
>> > with the fix.
>> 
>> Given that it's in a FreeBSD-only file, I think you can just commit and
>> cherry-pick it to the appropriate stable branch there.
>
> I agree, except I do not have commit access to KDE.  

Oh, sorry. I saw all those other commits to ksysguard in kde-workspace
with you as the author but didn't notice they were actually committed by
John.

In case you haven't contacted him yet, please ping me and I can commit
it for you.