[kde-freebsd] [PATCH/RFC] Fixing kinfocenter's usb support upstream

[Dima Panov]

On Sunday 04 October 2009 17:19:11 Raphael Kubo da Costa wrote:
> 2009/10/4 Raphael Kubo da Costa <kubito at gmail.com>:
> > Hey there,
> >
> > While I was building KDE trunk here today on 8.0-RC1, compilation would
> > fail on kdebase/apps/kinfocenter/usbview because 8.0 has got a
> > completely reworked USB stack from what I saw.
> >
> > I then found two patches in area51 (extra-patch-libusb20 and
> > patch-apps_kinfocenter_usbview_usbdevices.h from KDE/x11/kdebase4) that
> > fixed the issue in the port. After that I thought "why not push these
> > upstream?".
> >
> > The attached patch (which must be applied using
> > kdebase/apps/kinfocenter/usbview as the base directory) is what I
> > intend to commit to KDE's trunk (I don't know if it should be
> > backported): it basically integrates Fluffy's patches with the rest of
> > the code, allowing things to compile on previous FreeBSD releases as
> > well (pre-8.0).
> >
> > So I'd like to ask for some things here:
> >
> >  * Check if the patch looks OK for you;

Code seems to be fine.

> >  * If possible, test it on a pre-8.0 system (this is important);

Will do this as soon as possible.

> >  * Should it be backported to 4.3?

Yep. And, may be, request reroll for 4.3.2 (if it possible now) with patch included?

> >  * Fluffy: I've created GPLv2+ code based on your patch and Hans Petter
> >   Semalsky's; is it OK?
	  ^^^^^^^^
Hans Petter Selasky :) 

While all KDE is GPL'ed, it's ok. 
BSD license allows such use.

And while I'm a committer, using fluffy at freebsd.org more resposible :)

> I've just noticed the CMake check isn't working properly, which always
> leads to crashes. Until I fix it, I'd recommend waiting ;(

Ok, wait now :)

-- 
Dima "Red Fox" Panov @ Home | C73E 2B72 1FFD 61BD E206 1234 A626 76ED 93E3 B018
Khabarovsk, Russia          | 2D30 2CCB 9984 130C 6F87 BAFC FB8B A09D D539 8F29
KDE at FreeBSD Team | FreeBSD committer since 10.08.2009 | FreeBSD since Sept 1995
Twitter.com:fluffy_khv | Skype:dima.panov | Jabber.org:fluffy.khv | ICQ:1745024
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-freebsd/attachments/20091004/041182d1/attachment.sig