[kde-freebsd] [PATCH/RFC] Fixing kinfocenter's usb support upstream

Raphael Kubo da Costa kubito at gmail.com
Sun Oct 4 07:57:09 CEST 2009


Hey there,

While I was building KDE trunk here today on 8.0-RC1, compilation would
fail on kdebase/apps/kinfocenter/usbview because 8.0 has got a
completely reworked USB stack from what I saw.

I then found two patches in area51 (extra-patch-libusb20 and
patch-apps_kinfocenter_usbview_usbdevices.h from KDE/x11/kdebase4) that
fixed the issue in the port. After that I thought "why not push these
upstream?".

The attached patch (which must be applied using
kdebase/apps/kinfocenter/usbview as the base directory) is what I
intend to commit to KDE's trunk (I don't know if it should be
backported): it basically integrates Fluffy's patches with the rest of
the code, allowing things to compile on previous FreeBSD releases as
well (pre-8.0).

So I'd like to ask for some things here:

 * Check if the patch looks OK for you;
 * If possible, test it on a pre-8.0 system (this is important);
 * Should it be backported to 4.3?
 * Fluffy: I've created GPLv2+ code based on your patch and Hans Petter
   Semalsky's; is it OK?

Cheers,
Raphael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-build-on-FreeBSD-8.0.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-freebsd/attachments/20091004/08f744b5/attachment.patch 


More information about the kde-freebsd mailing list