[kde-freebsd] Fixing kdm defaults

[David Naylor]

On Sunday 22 November 2009 21:00:17 Raphael Kubo da Costa wrote:
> On Tuesday 17 November 2009 15:07:09 Raphael Kubo da Costa wrote:
> > On Tuesday 17 November 2009 09:56:19 David Bruce Naylor wrote:
> > > Hi,
> > >
> > > Although kdm reports the correct shutdown commands in the comments for
> > > the kdmrc file, these 'defaults' are not actually adhered to.
> > >
> > > This is due to a few missing includes resulting in the correct system
> > > not being detected (<sys/param.h> is missing, which means BSD never
> > > gets defined and thus kdm defaults to linux).
> > >
> > > It appears that the only place sys/param is included properly is in
> > >  genkdmconf which is enough for the comments about the default to be
> > >  correct but nothing more.
> > >
> > > See attached for a patch that fixes this.  It might be considered a bit
> > > of a hack but it fits in nicely with all the other 'hacks'.
> > >
> > > Regards,
> > >
> > > David
> > >
> > > P.S. I've submitted a bug report:
> >
> > Patches in Bugzilla have a high chance of being forgotten for ages. I
> >  suggest you either contact Oswald Buddenhagen, KDM's maintainer, post it
> >  via ReviewBoard or send it to the kde-devel or kde-core-devel mailing
> >  lists.
> >
> > Cheers,
> > Raphael
> 
> Hi, David,
> 
> Were you able to contact ossi?

Yes, I have.  He is aware of the bug report (I assume he will merge it as he 
didn't voice any objections to it).  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-freebsd/attachments/20091123/49a651d6/attachment.sig