[kde-freebsd] ports/135860: [PATCH] x11/kdebase3: Unbreak on -CURRENT

[Daniel Eischen]

The following reply was made to PR ports/135860; it has been noted by GNATS.

From: Daniel Eischen <deischen at freebsd.org>
To: Jeremy Messenger <mezz7 at cox.net>
Cc: bug-followup at freebsd.org
Subject: Re: ports/135860: [PATCH] x11/kdebase3: Unbreak on -CURRENT
Date: Sun, 5 Jul 2009 23:37:37 -0400 (EDT)

 On Sun, 5 Jul 2009, Jeremy Messenger wrote:
 
 > On Sun, 05 Jul 2009 20:01:59 -0500, Daniel Eischen <deischen at freebsd.org> 
 > wrote:
 >
 >> On Sun, 5 Jul 2009, Jeremy Messenger wrote:
 >> 
 >>> On Sun, 05 Jul 2009 11:09:04 -0500, Daniel M. Eischen <eischen at vigrid.com> 
 >>> wrote:
 >>> 
 >>>> I'm not sure why you disabled usb_revision.h.  It will not build on 
 >>>> -current without including this.
 >>> 
 >>> How old -CURRENT do you have? Have you ran 'make delete-old' when you 
 >>> update -CURRENT? It does not exist in today -CURRENT, see here:
 >> 
 >> My -current was a fresh install from June 2009 8.0 snapshot on amd64.
 >> I updated to -current sources from July 1, 2009, or thereabouts.
 >> I did not run 'make delete-old'.
 >> 
 >>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/usb/Attic/usb_revision.h 
 >>> (attic, removed)
 >>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/usb/ (no usb_revision.h)
 >>> 
 >>>> kde3 has been borken on -current for a while now.  Can we please get this
 >>>> incorporated?
 >>> 
 >>> Use my patch works great.
 >> 
 >> I am rebuilding to see if works now.  I'm not sure where those defines
 >> are going to come from though.  They don't appear to be anywhere else.
 >> 
 >> Are you going to commit this?
 >
 > No. I am not a KDE user and maintainer. :-) When I tested stuff with USB 
 > devices, I have no idea which it was works from HAL or KDE's USB stuff.. 
 > Mostly of stuff look like was from HAL, but I can't say for sure since I have 
 > no idea.
 
 Oh, okay.  BTW, it does not work with your patch:
 
 /bin/sh /usr/local/bin/libtool --silent --tag=CXX   --mode=compile c++ 
 -DHAVE_CONFIG_H -I. -I../..  -I/usr/local/include  -I/usr/local/include 
 -D_THREAD_SAFE -pthread -DQT_THREAD_SUPPORT   -I/usr/local/include 
 -I/usr/local/include  -I/usr/local/include -D_GETOPT_H -D_THREAD_SAFE 
 -D_LARGE_FILES=1  -Wno-long-long -Wundef -Wall -W -Wpointer-arith 
 -DNDEBUG -DNO_DEBUG -O2 -O2 -pipe -DLDAP_DEPRECATED -fno-strict-aliasing 
 -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common 
 -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT 
 -DQT_NO_TRANSLATION -D_GNU_SOURCE  -MT usbdevices.lo -MD -MP -MF 
 .deps/usbdevices.Tpo -c -o usbdevices.lo usbdevices.cpp
 usbdevices.cpp: In member function 'void 
 USBDevice::collectData(libusb20_backend*, libusb20_device*)':
 usbdevices.cpp:357: error: 'USB_SPEED_LOW' was not declared in this 
 scope
 usbdevices.cpp:358: error: 'USB_SPEED_FULL' was not declared in this 
 scope
 usbdevices.cpp:359: error: 'USB_SPEED_HIGH' was not declared in this 
 scope
 usbdevices.cpp:360: error: 'USB_SPEED_VARIABLE' was not declared in this 
 scope
 usbdevices.cpp:361: error: 'USB_SPEED_SUPER' was not declared in this 
 scope
 usbdevices.cpp: At global scope:
 usbdevices.cpp:329: warning: unused parameter 'pbe'
 usbdevices.cpp:379: warning: unused parameter 'fname'
 gmake[3]: *** [usbdevices.lo] Error 1
 gmake[3]: Leaving directory 
 `/opt/FreeBSD/ports/x11/kdebase3/work/kdebase-3.5.10/kcontrol/usbview'
 gmake[2]: *** [all-recursive] Error 1
 gmake[2]: Leaving directory 
 `/opt/FreeBSD/ports/x11/kdebase3/work/kdebase-3.5.10/kcontrol'
 gmake[1]: *** [all-recursive] Error 1
 gmake[1]: Leaving directory 
 `/opt/FreeBSD/ports/x11/kdebase3/work/kdebase-3.5.10'
 gmake: *** [all] Error 2
 *** Error code 1
 
 Those defines do not exist anywhere (after 'make delete-old') that
 I can find in /usr/include on -current.
 
 -- 
 DE