[kde-freebsd] kipi-plugins-kde4 port ready for testing

[Kris Moore]

Matt wrote:
> On Wed, Jan 28, 2009 at 3:12 PM, Max Brazhnikov <makc at issp.ac.ru> wrote:
>> On Wed, 28 Jan 2009 13:17:12 -0600, Matt wrote:
>>> Hi all.
>>>
>>> I've attached a slightly updated version of Kris's kipi-plugins-kde4
>>> port.  The suggested changes are as follow:
>>>
>>> 1. Add textproc/expat2 as a dependency to build the dngconverter component
>>> 2. Add bin/dngconverter to the pkg-plist
>>> 3. Add pimlibs to the USE_KDE4 list to satisfy the (optional) calendar
>>> component 4. Add USE_QT_VER=4 to bring in the qt4 dep
>>> 5. Specify "corelib gui qmake_build moc_build rcc_build uic_build" for
>>> QT_COMPONENTS (don't know if that's the right list off-hand, but it
>>> made the tinderbox build happy)
>> Yep, that's right.
>>
>>> 6. Add kdenetwork4 build dependency to bring in kdcraw, kipi and kexiv2
>> You've meant kdegraphics4. btw it should be LIB_DEPs, isn't it?
> 
> Oops - yes, kdegraphics4.  Thinking back on that, I have no idea why I
> put that in there as a build dep...testing for libkipi as a
> lib_depends makes sense.  This look right:
> 
> kipi.6:${PORTSDIR}/graphics/kdegraphics4
> 
>>> 7. Remove the "post-extract" target (didn't look like it was needed?)
>>> 8. Remove the "post-patch" as there were no instances of "pkgconfig"
>>> in the original CMakeLists.txt files and the patch was actually
>>> clobbering some items that were inserted into the root CMakeLists.txt
>>> by the patch in "files"
>>>
>>> I also slightly modified the CMakeLists.txt patch:
>>> 1. Added a "set(KDCRAW_FOR_DNGCONVERTER TRUE)" into the kdcraw
>>> detection routine to set this value and tell the build it was OK to
>>> compile dgnconverter.
>>> 2. Removed the (broken) kdcraw package detection that was originally
>>> being used to set the KDCRAW_FOR_DNGCONVERTER value.
>>>
>>> I've also been working on a digikam port for their 0.10.x series for
>>> KDE4 and that port is picking up these new kipi-plugins as I would
>>> expect them to!
>>>
>>> Hope this helps.  Let me know if there's anything else I can test.
>>>
>>> Matt
>> Great!
>>
>>
> _______________________________________________
> kde-freebsd mailing list
> kde-freebsd at kde.org
> https://mail.kde.org/mailman/listinfo/kde-freebsd
> See also http://freebsd.kde.org/ for latest information
> 

Those changes look great, thanks for improving the port, I didn't 
realize it was missing the DNG Converter :)

-- 

Kris Moore
PC-BSD Software
http://www.pcbsd.com