[kde-freebsd] pkg_info confusion (and configure.kde3)

[Garrett Cooper]

On Thu, Jan 15, 2009 at 7:08 AM, Andriy Gapon <avg at icyb.net.ua> wrote:
> on 15/01/2009 17:06 Wesley Shields said the following:
>> On Thu, Jan 15, 2009 at 03:31:32PM +0200, Andriy Gapon wrote:
>>> on 15/01/2009 15:29 matt donovan said the following:
>>>>
>>>> On Thu, Jan 15, 2009 at 8:11 AM, Andriy Gapon <avg at icyb.net.ua
>>>> <mailto:avg at icyb.net.ua>> wrote:
>>>>
>>>>
>>>>     I am reading pkg_info(1), I see that pkg_info can be executed without
>>>>     any options/arguments, but the man page doesn't tell what happens in
>>>>     this case.
>>>>
>>>>     In practice I see that configure.kde3 executes pkg_info in the above
>>>>     fashion (after printing "Looking for installed modules.") and what I
>>>>     observe is that pkg_info is examining all package files found in
>>>>     /var/packages. This takes quite long, obviously:
>>>>
>>>>
>>>>        0 61827 28318   0   8  0  5992  2892 wait   S+J   p5    0:00.12
>>>>     /usr/sbin/pkg_info
>>>>        0 62162 61827   0   8  0  3492  1108 wait   S+J   p5    0:00.00 sh
>>>>     -c /usr/bin/tar -xp -j -f '/var/packages/All/curl-7.18.0.tbz' '+*'
>>>>
>>>>     I am not sure if this is default behavior of pkg_info or it is somehow
>>>>     affected by environment. I run portupgrade -p and also have PACKAGES set
>>>>     to /var/packages.
>>>>
>>>>     --
>>>>     Andriy Gapon
>>>>     _______________________________________________
>>>>     freebsd-ports at freebsd.org <mailto:freebsd-ports at freebsd.org> mailing
>>>>     list
>>>>     http://lists.freebsd.org/mailman/listinfo/freebsd-ports
>>>>     To unsubscribe, send any mail to
>>>>     "freebsd-ports-unsubscribe at freebsd.org
>>>>     <mailto:freebsd-ports-unsubscribe at freebsd.org>"
>>>>
>>>>
>>>> pkg_info run without args is the default way to run pkg_info it just
>>>> prints out all packages/ports installed
>>> Ok, but what did make it peek into the package files (as shown in ps axl
>>> output above)?
>>
>> The output looks like this:
>>
>> zsh-4.3.9_4         The Z shell
>>
>> The second field comes from the +COMMENT file that lives in
>> /var/db/pkg/foo.
>
> Thanks, but my question was:
>> sh -c /usr/bin/tar -xp -j -f '/var/packages/All/curl-7.18.0.tbz' '+*'
> why this command (and such for every package in /var/packages/All) was
> spawned by pkg_info?
> I.e. why pkg_info looks into package .tbz files instead of examining
> /var/db/pkg?

Looks like bad logic to me. Here's where the call is coming from (mind
you I'm referencing pkg_install from CURRENT's sources):

.../usr.sbin/pkg_install/info/perform.c:142           if
(unpack(fname, "'+*'")) {
.../usr.sbin/pkg_install/lib/file.c:354                      if
(vsystem("/usr/bin/tar -xp %s -f '%s' %s", comp, pkg, flist ? flist :
"")) {

Looking at the if-statement, it appears that the logic for the package
finding is in fact sort of convoluted -- we should first check and see
whether or not the package is installed, THEN if it's not installed we
find the tarball (either from a local filesystem or a remote host),
extract it, and grab the appropriate info.

Does that sound like what should happen?

Thanks,
-Garrett