[kde-freebsd] [CFT] new bsd.cmake.mk world order

[David Naylor]

On Tuesday 20 May 2008 14:56:47 you wrote:
> Hi Floks,
>
> Few months ago David Yeske partly wrote a USE_CMAKE framework for the
> bsd.ports.mk, in the last times I got no feedback from him about the
> current status. Yesterday I was a bit bored and I took over his
> work and rewrote it from scratch in a bsd.cmake.mk. For upcoming KDE4
> we need a cmake build framework which now is complete. Now I would like
> to hear what you think about this work.
>
> http://people.freebsd.org/~miwi/cmake/cmstuff.diff
Can you please explain the use of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS?  Why not 
just stick to C_FLAGS and CXX_FLAGS (is there a specific case where the two 
sets of flags would need to differ?).  

I would prefer only cmake specific parameters be used by CMAKE_, since C_FLAGS 
and such are generic should they not stay that way (provided above case is 
not met).  

Also, just like ./configure cmake does pick up default values for CC, C_FLAGS, 
etc from the env if not specified on the command line.  Is there a value in 
being so specific/verbose (see my proposed bsd.cmake.mk 
[http://mail.kde.org/pipermail/kde-freebsd/2008-January/001903.html] for an 
example)?

Since moving to 7 and -current I have not had a problem with pthread.  Is it 
only a problem with 6 and from 7 a mute point?  Any explanation about the 
pthread problem welcome.  (I just know when linking problems occur with 
pthread mentions it needs to be included...)

>
> Please test, review these all and let me know what you think. Of Course
> Feedback, proposals are Welcome :-)
I looked through your patch.  It looks clean and I see that you have converted 
many (if not all) ports to using your cmake (with minimal amount of code :-).  
Excellent.  Just the way it should be done :->

The patch does not appear to check the return status of cmake.  

>
> PS:
> And i like to say thanks to itetcu@, stas@, and Dmitry Marakasov, for
> review, comments and suggestions.

Regards

David


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-freebsd/attachments/20080521/e7fabb3d/attachment.pgp