[kde-freebsd] 8-current/kde3 stty defaults incorrect under konsole

[Ed Schouten]

KDE folks,

* Mark Atkinson <atkin901 at yahoo.com> wrote:
> Ed Schouten wrote:
> 
> > Hello Mark,
> > 
> > * Mark Atkinson <atkin901 at yahoo.com> wrote:
> >> Hi,
> >> 
> >> Is anyone else running freebsd-current with kde3 (and has rebuilt both
> >> recently)?   I can only suspect this is related to recent changes in
> >> current in prep for mpsafe tty, but in konsole, the defaults turn out to
> >> be this (note the missing '^' on intr and quit):
> >> 
> >> cchars: discard = ^O; dsusp = ^Y; eof = ^D; eol = <undef>;
> >>         eol2 = <undef>; erase = ^?; erase2 = ^H; intr = C; kill = ^U;
> >>         lnext = ^V; min = 1; quit = \; reprint = ^R; start = ^Q;
> >>         status = ^T; stop = ^S; susp = ^Z; time = 0; werase = ^W;
> >> 
> >> xterm and the freebsd console are fine.
> >> 
> >> Maybe related to this commit?
> > 
> > Blegh. I always hate those applications using non-documented extensions
> > in a non-standard way. ;-)
> > 
> > Anyway, could you store this patch in the files/ dir of the kdelibs3
> > port and see what happens? Thanks! :)
> > 
> > %%%
> > --- kdecore/kpty.cpp
> > +++ kdecore/kpty.cpp
> > @@ -128,9 +128,8 @@
> >  #include <kstandarddirs.h>   // locate
> >  
> >  // not defined on HP-UX for example
> > -#ifndef CTRL
> > -# define CTRL(x) ((x) & 037)
> > -#endif
> > +#undef CTRL
> > +#define CTRL(x) ((x) & 037)
> >  
> >  #define TTY_GROUP "tty"
> >  
> > %%%
> 
> That appears to work, thanks for the quick reply!

Would you mind if I add this patch to the kdelibs3 port? It is needed to
make control characters work with konsole, which seems to be broken on
-CURRENT, because the CTRL() macro has been slightly changed.

%%%
--- kdecore/kpty.cpp
+++ kdecore/kpty.cpp
@@ -128,9 +128,8 @@
 #include <kstandarddirs.h>   // locate
 
 // not defined on HP-UX for example
-#ifndef CTRL
-# define CTRL(x) ((x) & 037)
-#endif
+#undef CTRL
+#define CTRL(x) ((x) & 037)
 
 #define TTY_GROUP "tty"
 
%%%

Yours,
-- 
 Ed Schouten <ed at 80386.nl>
 WWW: http://80386.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-freebsd/attachments/20080625/f0126361/attachment.pgp