[kde-freebsd] More changes needed for building net/kdenetwork4 version 4.1.85

[Matt]

On Wed, Dec 24, 2008 at 9:38 AM, Thomas Abthorpe <tabthorpe at freebsd.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On December 23, 2008 10:45:29 pm Matt wrote:
...
>> There are also some other dependent libraries that the kdenetwork4
>> port is looking for.  Do we want to include any of these by default or
>> and config options for them?  The tinderbox build log shows:
>>
>> ---------------------------------------------------------------------------
>>-- -- The following OPTIONAL packages could NOT be located on your system.
>> -- Consider installing them to enable more features from this software. +
>> libnxcl, 1.0 or higher: NX X compression client library
>> <http://svn.berlios.de/svnroot/repos/freenx/trunk/freenx-client/nxcl/>
>> Needed to build Krdc with NX support
>> + libortp, 0.13 or higher: oRTP provides an API to send rtp packets
>> <http://www.linphone.org/index.php/eng/code_review/ortp>
>> Needed to build Jingle support in Kopete.
>> + Decibel: KDE framework for real-time communication
>> <http://decibel.kde.org/> Used by the Kopete telepathy protocol.
>> + GMP: The GNU Multiple Precision Arithmetic Library <http://gmplib.org/>
>> Needed to build KGet Torrent support.
>> + WebKitKde: Webkitkde libraries and header files <>
>> Webkitkde is necessary to compile support for WebKitKde.
>> + XMMS: X MultiMedia System development libraries <http://www.xmms.org>
>> Used by the Kopete nowlistening plugin to support the XMMS player.
>> + libmeanwhile: A library for protocol support for connection to
>> Sametime servers <http://meanwhile.sf.net>
>> Required for the Kopete Meanwhile protocol
>> ---------------------------------------------------------------------------
>>--
>
> My initial answer is to say, provide a patch for adding optional componenents,
> and we will add it in!
>
Here's a start at it.  Options have been added for Meanwhile, GMP,
oRTP, Decibel and XMMS and the plist has been updated with extra
optional files that are built with the Meanwhile and GMP options.  It
builds OK in tinderbox, but I haven't run-tested it yet.

Some observations from this configuration:

- I added an explicit dependency on the OpenSSL port because of a
problem I've been having since version 4.1.3.  If that dependency is
not there and I have the OpenSSL port installed, Kopete core dumps
when I connect to my GroupWise chat server (which is an SSL
connection).  I'm sure there is an underlying cause for this -
suggestions welcome.

- Only the Meanwhile option is accompanied by a corresponding cmake
value in the src cmake files, which is why it's the only one that I've
added a CMAKE_ARGS line for in the Makefile.

- Without an explicit option to disable the GMP dependency at
configure and build time, the plist generation will be incorrect if a
user does not enable the GMP option but has the math/libgmp4 port
installed when they run a make on the kdenetwork4 port.  This is
because the GMP test is on by default in the kdenetwork4 configure
script and if it finds the library it will include the option in the
build resulting in two extra files being installed.  Any good ways
around this?

- The oRTP, Decibel and XMMS detection works the same way as GMP, but
these options are not resulting in extra files being installed.

- The oRTP detection in cmake/modules/FindLiboRTP.cmake is not working
correctly.  The patch shown below works around the issue, but it
doesn't seem like the "right" thing to do.

--- ../cmake/modules/FindLiboRTP.cmake.orig     2008-12-26
22:20:02.000000000 -0600
+++ ../cmake/modules/FindLiboRTP.cmake  2008-12-26 22:22:03.000000000 -0600
@@ -14,7 +14,7 @@
 SET( LIBORTP_FOUND FALSE )

 IF( LIBORTP_INCLUDE_DIR AND LIBORTP_LIBRARY )
-  EXECUTE_PROCESS( COMMAND gcc -o ortpversion -lortp
-L${LIBORTP_INCLUDE_DIR}
${CMAKE_SOURCE_DIR}/cmake/modules/ortpversion.c OUTPUT_QUIET
ERROR_QUIET RESULT_VARIABLE compileErr )
+  EXECUTE_PROCESS( COMMAND gcc -I/usr/local/include -o ortpversion
-lortp -L/usr/local/lib
${CMAKE_SOURCE_DIR}/cmake/modules/ortpversion.c OUTPUT_QUIET
ERROR_QUIET RESULT_VARIABLE compileErr )
   if ( NOT compileErr )
     EXECUTE_PROCESS(COMMAND ./ortpversion 0 13 RESULT_VARIABLE resultErr )
     if ( NOT resultErr )
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-Makefile-kdenetwork4
Type: application/octet-stream
Size: 1803 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-freebsd/attachments/20081227/a262cdc9/attachment-0002.dll 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pkg-plist.patch_kdenetwork4
Type: application/octet-stream
Size: 39957 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-freebsd/attachments/20081227/a262cdc9/attachment-0003.dll