Question a bout a possible bug in KBookmarkAction

[Albert Astals Cid]

El dilluns, 9 de juny del 2025, a les 18:06:51 (Hora d’estiu d’Europa 
central), Stefano Crocco va escriure:
> On lunedì 9 giugno 2025 16:07:17 Ora legale dell’Europa centrale Albert
> Astals
> Cid wrote:
> > El diumenge, 8 de juny del 2025, a les 15:01:06 (Hora d’estiu d’Europa
> > 
> > central), Stefano Crocco va escriure:
> > > Hello to everyone,
> > > I was investigating why in Konqueror middle-clicking on a bookmark in
> > > the
> > > bookmarks menu doesn't open the bookmark in a new tab like it used to do
> > > a
> > > while ago
> > 
> > Do you know when it broke more or less?
> > 
> > Looking at the code it seems it has been broken since KF 5?
> > 
> > Cheers,
> > 
> >   Albert
> 
> Yes, I think it has. I just checked using an old PC with Qt 5.15.10 and KF
> 5.107.0 and Konqueror (version 23.04.2) seems to behave the same way. I
> thought the problem was more recent, but it seems I was wrong.

It is defenitely a bug in KBookmarks.

KBookmarkAction::slotTriggered can not use QGuiApplication::mouseButtons() 
beacuse it's too late, the action gets triggered by releasing the mouse, so at 
that point mouseButtons will correctly return NoButton.

Fixing the bug needs something similar to what you are doing.

I've done https://invent.kde.org/frameworks/kbookmarks/-/merge_requests/65

Reviews?

Cheers,
  Albert

> 
> Stefano