Unexpected behavior in KIO::MimeTypeFinderJob

[David Faure]

On mercredi 7 août 2024 08:30:43 heure d’été d’Europe centrale Stefano Crocco 
wrote:
> Hello to everyone,
> while investigating a bug in Konqueror, I just found what in my opinion is
> an unexpected behavior of KIO::MimeTypeFinderJob. If I'm reading the code
> correctly, when it uses KIO::get() to determine the mimetype [1], it lets
> the TransferJob go on even after it detected the mimetype.
> 
> The documentation for KIO::get() states:
> "Special case: if you want to determine the MIME type of the file first, and
> then read it with the appropriate component, you can still use a KIO::get()
> directly. When that job emits the mimeType signal, (which is guaranteed to
> happen before it emits any data), put the job on hold".  Since the task of
> MimeTypeFinderJob is finding the mimetype of the URL, I expected it would
> put the job on hold as soon as it has determined the mimetype, coherently
> with the KIO::get() documentation.

Right, that's what KRun::foundMimeType was doing, and I did that in 
MimeTypeFinderJob initially.

But see commit 621585f0e818cd9f75cdd3bcc8665da7ac708283
and bug 452729. Seems weird. Talk to Harald ;)
 
-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20240807/106bbe10/attachment.sig>