beware KF5 5.100 version checks

[Jonathan Riddell]

This week I got most confused by files moving around again in our
packages.  It turns out several apps have checks on ECM version for new
KDEInstallDirs that were added around ECM 5.57.  If the app uses

if(${ECM_VERSION} STRGREATER "5.57.0")

It will break with KF5 5.100

Instead it should use

if(${ECM_VERSION} VERSION_GREATER "5.57.0")

Or just depend on a newer ECM version, a few apps we've found had these
broken version checks but depended on a newer ECM version anyway so the
test can be removed.

Examples:
https://invent.kde.org/office/tellico/-/merge_requests/6/diffs
https://invent.kde.org/graphics/okular/-/merge_requests/666/diffs

Jonathan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20221021/0fad7a85/attachment.htm>