D29805: Thumbnail djvu: Avoid a crash when djvu is not installed
Méven Car
noreply at phabricator.kde.org
Sat May 30 17:29:33 BST 2020
meven added a comment.
In D29805#674225 <https://phabricator.kde.org/D29805#674225>, @pino wrote:
> In D29805#674218 <https://phabricator.kde.org/D29805#674218>, @meven wrote:
>
> > In D29805#674206 <https://phabricator.kde.org/D29805#674206>, @pino wrote:
> >
> > > In D29805#674205 <https://phabricator.kde.org/D29805#674205>, @meven wrote:
> > >
> > > > In D29805#674204 <https://phabricator.kde.org/D29805#674204>, @pino wrote:
> > > >
> > > > > > FIXED-IN: 20.08
> > > > >
> > > > > still for 20.08...
> > > >
> > > >
> > > > Yes kio-extra is released with KDE Applications
> > >
> > >
> > > Yes, I know. Asked to land this fix instead to `release/20.04`, and thus change the commit message accordingly.
> >
> >
> > Please be explicit when you comment, no one could deduce what you meant.
>
>
> I wrote it **two** times to land this on the stable branch: the first time when I explained why the initial patch was not correct and what the problem actually was (with hints on short term and long term fixes), and earlier today when I wrote:
>
> In D29805#674185 <https://phabricator.kde.org/D29805#674185>, @pino wrote:
>
> > please target `release/20.04` for this fix, thanks
>
>
> There is no need to "deduce" anything, just read what I wrote, thanks.
>
> > If this is ready approve and add a comment "land to 20.04".
>
> The commit message still says "20.08", so not yet.
That's a detail once it is accepted it is trivial to edit...
Usually this is not required.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D29805
To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200530/d6fbb264/attachment.htm>
More information about the Kde-frameworks-devel
mailing list