D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I have modified DesktopExecParser in kio commit d1e9325fba37eddb9cb44173edfc1fee122a0c57 <https://phabricator.kde.org/R241:d1e9325fba37eddb9cb44173edfc1fee122a0c57> to return an error string so that its users don't need to do the work again of figuring out what went wrong (see DesktopExecParser::errorMessage()).
  I just realized that this would be very useful here as well. AFAICS the current patch only works if the user types a full path, not with a relative path.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29445

To: broulik, #frameworks, #vdg, dfaure
Cc: ahmadsamir, dfaure, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200529/9dc44682/attachment.htm>