D29668: Do not reject icon theme dir with invalid context/type.

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kicontheme.cpp:761
>      } else if (tmp.isEmpty()) {
>          // do nothing. key not required
>      } else {

(OK, if this key is not required then surely unknown values are fine too..)

> kicontheme.cpp:774
>          qWarning() << "Invalid Type=" << tmp << "line for icon theme: " << constructFileName(QString());
> -        return;
> +        mType = KIconLoader::Threshold;
>      }

So, if index.theme says `Type=Fixed`, why did you change this line? It should work without this second change, only the first one seems useful.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29668

To: xuetianweng, #frameworks, dfaure, apol
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200526/09676bc6/attachment-0001.htm>