D29397: KPreviewJob : Support for DeviceRatioPixel

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> previewjob.cpp:587
> +    if (thumb.textKeys().contains(QStringLiteral("Thumb::DevicePixelRatio"))) {
> +        qreal dpr = thumb.text(QStringLiteral("Thumb::DevicePixelRatio")).toDouble();
> +        thumb.setDevicePixelRatio(dpr);

Missing `const`

> previewjob.h:192
> +    /**
> +     * Request preview to use the device pixel ratio @p.
> +     * The returned thumbnail may not respect the device pixel ratio returned.

Did you mean `@p dpr`?

(unless doxygen is smart enough to figure out the name of the parameter?)

> previewjob.h:268
> +     */
> +    static void setDefaultDevicePixelRatio(qreal devicePixerRatio);
>  };

Typo: `devicePixelRatio`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200523/b9d39cd6/attachment-0001.htm>